Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query compiler method to_dataframe should be named to_interchange or similar #7418

Closed
sfc-gh-mvashishtha opened this issue Jan 10, 2025 · 1 comment · Fixed by #7422
Closed

Query compiler method to_dataframe should be named to_interchange or similar #7418

sfc-gh-mvashishtha opened this issue Jan 10, 2025 · 1 comment · Fixed by #7422
Assignees
@sfc-gh-mvashishtha
Labels
Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects

Comments

@sfc-gh-mvashishtha
Copy link
Contributor

The name to_dataframe() does not reflect the method's purpose, which is to produce a dataframe interchange protocol object.
@sfc-gh-mvashishtha sfc-gh-mvashishtha added the Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects label Jan 10, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha self-assigned this Jan 10, 2025
sfc-gh-mvashishtha added a commit to sfc-gh-mvashishtha/modin that referenced this issue Jan 16, 2025
@sfc-gh-mvashishtha
REFACTOR-modin-project#7418: Rename to_dataframe to to_interchange_da…
0e57d6b 
…taframe.

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
@sfc-gh-mvashishtha sfc-gh-mvashishtha mentioned this issue Jan 16, 2025
Merged
7 tasks
sfc-gh-mvashishtha added a commit that referenced this issue Jan 16, 2025
@sfc-gh-mvashishtha
REFACTOR-#7418: Rename internal interchange protocol methods. (#7422)
4cae985 
Rename internal `to_dataframe` methods to `to_interchange_dataframe`, and internal `from_dataframe` methods to `from_interchange_dataframe`.

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-mvashishtha sfc-gh-mvashishtha

Labels
Interfaces and abstractions Issues with Modin's QueryCompiler, Algebra, or BaseIO objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#7418: Rename internal interchange protocol methods. sfc-gh-mvashishtha/modin
2 participants
@sfc-gh-mvashishtha and others