Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: merge dask and ray virtual partition code #4696

Open
mvashishtha opened this issue Jul 21, 2022 · 0 comments · May be fixed by #4759
Open

REFACTOR: merge dask and ray virtual partition code #4696

mvashishtha opened this issue Jul 21, 2022 · 0 comments · May be fixed by #4759
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P1 Important tasks that we should complete soon

Comments

@mvashishtha
Copy link
Collaborator

System information

  • Modin version (modin.__version__): cc3bdb7

Now that both Ray and Dask block partitions use _data to store physical data, I think we should be able to de-duplicate the fairly complex virtual partition code for ray and dask.
@mvashishtha mvashishtha mentioned this issue Jul 22, 2022
Merged
8 tasks
@mvashishtha mvashishtha self-assigned this Aug 2, 2022
@mvashishtha mvashishtha added the Code Quality 💯 Improvements or issues to improve quality of codebase label Aug 2, 2022
mvashishtha pushed a commit to mvashishtha/modin that referenced this issue Aug 2, 2022
REFACTOR-modin-project#4696: Merge dask and ray virtual partition code.
81f3c5e 
Signed-off-by: mvashishtha <[email protected]>
@mvashishtha mvashishtha linked a pull request Aug 2, 2022 that will close this issue
Draft
8 tasks
@pyrito pyrito added the P3 Very minor bugs, or features we can hopefully add some day. label Aug 31, 2022
@mvashishtha mvashishtha added P1 Important tasks that we should complete soon and removed P3 Very minor bugs, or features we can hopefully add some day. labels Sep 22, 2022
@mvashishtha mvashishtha removed their assignment May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P1 Important tasks that we should complete soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#4696: Merge dask and ray virtual partition code. mvashishtha/modin
2 participants
@pyrito @mvashishtha