-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ray] Add unit tests for ray client + modin #3085
Comments
Having some CI coverage here would really help with making sure we have native support for Modin with Ray Client. We can also add tests for this on the Ray CI. Another relevant issue is here #2688 |
@devin-petersohn any guidance on how to go about adding this to modin CI? I think ideally we can just run the same tests that currently exist for modin on ray, except with ray client. |
For this, we would probably want to add a separate job within the existing CI and push for the GitHub Actions (not necessary for our TeamCity tests). We would need to start the client before running the tests. Modin will automatically connect to the client if you run with environment variable |
@devin-petersohn Hey Devin, just wanted to check two things that would help get this closed:
|
^ First thing should be fine for now, we'll just install the latest commit when testing for now. |
@ckw017 thanks for following up! 1.) We are planning to release 0.10 tomorrow (probably 😄). After release it'll probably be good to test the stable release since we are planning major changes for the release after 0.10. |
Signed-off-by: Chris Wong <[email protected]>
Signed-off-by: Chris Wong <[email protected]>
Signed-off-by: Chris Wong <[email protected]>
Signed-off-by: Chris Wong <[email protected]>
….yml Signed-off-by: Chris Wong <[email protected]>
Signed-off-by: Chris Wong <[email protected]>
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
Wanted to open discussion about adding unit tests using ray client to this repo's CI. If there are any examples that should be covered that would be handy to know, as well as any guidelines for where to put these tests. Example issue with ray-client on the ray repo ray-project/ray#14857.
@amogkam @devin-petersohn
The text was updated successfully, but these errors were encountered: