Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClusterError class should implement its own version of __str__ method #1781

Closed
anmyachev opened this issue Jul 23, 2020 · 2 comments · Fixed by #1782
Closed

ClusterError class should implement its own version of __str__ method #1781

anmyachev opened this issue Jul 23, 2020 · 2 comments · Fixed by #1782
Assignees
@anmyachev
Milestone
0.8.0

Comments

@anmyachev
Copy link
Collaborator

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
  • Modin installed from (source or binary):
  • Modin version:
  • Python version:
  • Exact command to reproduce:

Describe the problem

ClusterError includes the cause field that is not printed. This makes it difficult to understand the problems that cause exceptions.

Source code / logs
@anmyachev anmyachev self-assigned this Jul 23, 2020
@anmyachev anmyachev mentioned this issue Jul 23, 2020
Merged
6 tasks
@devin-petersohn
Copy link
Collaborator

@anmyachev Is this a part of the next release 0.8.0?

@anmyachev
Copy link
Collaborator Author

@anmyachev Is this a part of the next release 0.8.0?

Yes. I added the issue to 0.8.0 release.

anmyachev added a commit to anmyachev/modin that referenced this issue Jul 23, 2020
@anmyachev
FEAT-modin-project#1781: implement ClusterError.__str__
2b83a73 
Update modin/experimental/cloud/base.py

Co-authored-by: Vasily Litvinov <[email protected]>

Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Vasilij Litvinov <[email protected]>
@devin-petersohn devin-petersohn added this to the 0.8.0 milestone Jul 23, 2020
devin-petersohn pushed a commit that referenced this issue Jul 23, 2020
@anmyachev @vnlitvinov
FEAT-#1781: implement ClusterError.__str__ (#1782)
731816d 
Co-authored-by: Vasily Litvinov <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@anmyachev @vnlitvinov @aregm
FEAT-modin-project#1781: implement ClusterError.__str__ (modin-projec…
2ef9c43 
…t#1782)

Co-authored-by: Vasily Litvinov <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anmyachev anmyachev

Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

FEAT-#1781: implement ClusterError.__str__ anmyachev/modin
2 participants
@devin-petersohn @anmyachev