-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort_values inplace=True clears dataframe contents #1743
Labels
bug 🦗
Something isn't working
Comments
5 tasks
gshimansky
added a commit
to gshimansky/modin
that referenced
this issue
Jul 17, 2020
Signed-off-by: Gregory Shimansky <[email protected]>
gshimansky
added a commit
to devin-petersohn/modin
that referenced
this issue
Jul 20, 2020
This test runs inplace sort of dataframe that has non-numerical index Signed-off-by: Gregory Shimansky <[email protected]>
anmyachev
added a commit
that referenced
this issue
Jul 21, 2020
* Move logic of `sort_values` into the query compiler Signed-off-by: Devin Petersohn <[email protected]> * Remove dead code Signed-off-by: Devin Petersohn <[email protected]> * Add back `"kind"` parameter Signed-off-by: Devin Petersohn <[email protected]> * Added a test for bug #1743 This test runs inplace sort of dataframe that has non-numerical index Signed-off-by: Gregory Shimansky <[email protected]> * Apply suggestions from code review Co-authored-by: anmyachev <[email protected]> Co-authored-by: Gregory Shimansky <[email protected]> Co-authored-by: anmyachev <[email protected]>
Fixed as a part of #1754 |
aregm
pushed a commit
to aregm/modin
that referenced
this issue
Sep 16, 2020
* Move logic of `sort_values` into the query compiler Signed-off-by: Devin Petersohn <[email protected]> * Remove dead code Signed-off-by: Devin Petersohn <[email protected]> * Add back `"kind"` parameter Signed-off-by: Devin Petersohn <[email protected]> * Added a test for bug modin-project#1743 This test runs inplace sort of dataframe that has non-numerical index Signed-off-by: Gregory Shimansky <[email protected]> * Apply suggestions from code review Co-authored-by: anmyachev <[email protected]> Co-authored-by: Gregory Shimansky <[email protected]> Co-authored-by: anmyachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System information
Ubuntu 20.04
modin.__version__
):0.7.4+28.g7c94902
Python 3.8.2
Describe the problem
This code when ran on Modin produces a dataframe with NaN contents instead of sorted values.
Source code / logs
The text was updated successfully, but these errors were encountered: