Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance for df.items and other iterators #1598

Closed
devin-petersohn opened this issue Jun 15, 2020 · 0 comments · Fixed by #1599
Closed

Performance for df.items and other iterators #1598

devin-petersohn opened this issue Jun 15, 2020 · 0 comments · Fixed by #1599
Assignees
@devin-petersohn
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@devin-petersohn
Copy link
Collaborator

Looping over the Modin dataframe is slow when you use df.items and other iterators. Part of this is because we are still materializing the data in the driver. This does not scale.

Since we have better indexing performance, we should take advantage of that here.
@devin-petersohn devin-petersohn self-assigned this Jun 15, 2020
@devin-petersohn devin-petersohn added the Performance 🚀 Performance related issues and pull requests. label Jun 15, 2020
@devin-petersohn devin-petersohn mentioned this issue Jun 15, 2020
Merged
5 tasks
devin-petersohn added a commit to devin-petersohn/modin that referenced this issue Jul 22, 2020
@devin-petersohn
FEAT-modin-project#1598: Update iterator implemetion to iloc
7358b5d 
Co-authored-by: Dmitry Chigarev <[email protected]>

Signed-off-by: Devin Petersohn <[email protected]>
dchigarev pushed a commit that referenced this issue Jul 24, 2020
@devin-petersohn
FEAT-#1598: Update iterator implemetion to iloc (#1599)
21b515b 
Co-authored-by: Dmitry Chigarev <[email protected]>

Signed-off-by: Devin Petersohn <[email protected]>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@devin-petersohn @aregm
FEAT-modin-project#1598: Update iterator implemetion to iloc (modin…
222b4a9 
…-project#1599)

Co-authored-by: Dmitry Chigarev <[email protected]>

Signed-off-by: Devin Petersohn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devin-petersohn devin-petersohn

Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change iterators to start using indexing with loc devin-petersohn/modin
1 participant
@devin-petersohn