Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geometry): is_clockwise() now works as expected for a disv problem #1374

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix(geometry): is_clockwise() now works as expected for a disv problem #1374

merged 2 commits into from
Mar 16, 2022

Conversation

emorway-usgs
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1374 (d90750e) into develop (8ae9b4d) will decrease coverage by 44.731%.
The diff coverage is 0.000%.

@@              Coverage Diff               @@
##           develop     #1374        +/-   ##
==============================================
- Coverage   74.800%   30.068%   -44.732%     
==============================================
  Files          249       249                
  Lines        53568     52148      -1420     
==============================================
- Hits         40069     15680     -24389     
- Misses       13499     36468     +22969     
Impacted Files Coverage Δ
flopy/utils/geometry.py 24.937% <0.000%> (-50.375%) ⬇️
flopy/mf6/utils/testutils.py 0.000% <0.000%> (-93.334%) ⬇️
flopy/mfusg/mfusgsms.py 6.161% <0.000%> (-91.514%) ⬇️
flopy/mf6/utils/postprocessing.py 9.259% <0.000%> (-88.889%) ⬇️
flopy/modflow/mfevt.py 7.812% <0.000%> (-87.007%) ⬇️
flopy/mf6/utils/lakpak_utils.py 2.097% <0.000%> (-85.315%) ⬇️
flopy/modflow/mfhyd.py 13.223% <0.000%> (-85.124%) ⬇️
flopy/utils/swroutputfile.py 10.714% <0.000%> (-85.079%) ⬇️
flopy/utils/mtlistfile.py 4.620% <0.000%> (-84.700%) ⬇️
flopy/modflowlgr/mflgr.py 6.271% <0.000%> (-84.354%) ⬇️
... and 205 more

Copy link
Contributor

@jlarsen-usgs jlarsen-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Automatic polygon closure was appending the incorrect vertex prior to this PR.

@christianlangevin
Copy link

test?

@christianlangevin christianlangevin merged commit 3a1d94a into modflowpy:develop Mar 16, 2022
@christianlangevin
Copy link

In the future it would make more sense to add this test of a small function to an existing autotest script (such as t032_test.py which uses flopy.utils.geometry) instead of creating a new source file to test this small function.

@emorway-usgs
Copy link
Contributor Author

I would be happy to move this new test over to t032 if helpful? I was not aware other flopy.util.geometry() tests were being collected there.

@emorway-usgs emorway-usgs deleted the fix4geom_is_clockwise branch March 19, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants