Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #11

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Updates #11

merged 3 commits into from
Oct 13, 2023

Conversation

lindseyolson
Copy link
Collaborator

  • Remove WordPressVIPMinimum.Variables.VariableAnalysis sniff because it's deprecated & replace with VariableAnalysis, which is now a dependency.
  • Remove patch for PHP8, which I believe is no longer needed from the discovery I did. It was throwing an error that the patch could not be applied for projects & I believe that when WPCS as updated to 3.0 it is no longer needed.

@defunctl
Copy link
Collaborator

@lindseyolson thanks! I'll test this this morning and get back to you

@defunctl defunctl self-assigned this Oct 13, 2023
@defunctl
Copy link
Collaborator

@lindseyolson I removed the entire composer patches library as it's not longer needed and set a minimum vipwpcs version now they finally added PHP8 support.

@defunctl defunctl merged commit 4639238 into 3.x Oct 13, 2023
@defunctl defunctl deleted the updates branch October 13, 2023 14:59
@lindseyolson
Copy link
Collaborator Author

Great thank you @defunctl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants