Introduce optimizer_base_type in support of different optimizers #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step toward decoupling the optimizer logic from the concrete layers.
This PR only introduces the abstract
optimizer_base_type
and a concretesgd
type.The update of weights is still hardcoded in
network % train
and the concrete layer implementations; decoupling that remains a TODO.In a nutshell, the idea is to have
sgd
,adam
, etc. innf_optimizers.f90
(and its submodules, eventually);adam(learning_rate, beta1, beta2, epsilon, ...)
)update
subroutine which would expect the needed gradients (dw
,db
) as input, and also the weights and biases arrays asintent(out)
to update.@rweed let me know if this approach seems reasonable to you.