Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model-datastructure): avoid stack overflows when adding many children at once #1328

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

odzhychko
Copy link
Contributor

@odzhychko odzhychko commented Jan 20, 2025

Avoid stack overflows when adding many children at once by executing reactive streams in Kotlin Flows.

  • Check how getAll and putAll could be added to CPHamtNode so that no long chains of flatMap/andThen are needed in the first place.
  • Check performance impact of changes.

To be verified by reviewers

  • Relevant public API members have been documented
  • Documentation related to this PR is complete
    • Boundary conditions are documented
    • Exceptions are documented
    • Nullability is documented if used
  • Touched existing code has been extended with documentation if missing
  • Code is readable
  • New features and fixed bugs are covered by tests

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Test Results

  199 files    199 suites   34m 18s ⏱️
1 099 tests 1 087 ✅ 8 💤 4 ❌
1 109 runs  1 097 ✅ 8 💤 4 ❌

For more details on these failures, see this check.

Results for commit 8d189af.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant