Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise CTest configuration #4490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Oct 27, 2024

  • include(CTest) dependency is not required and considered controversial because it introduces extra build targets. Instead enable_testing() is good enough. I read about it here and here from the CMake experts, for example.
  • Introduce MODELICA_BUILD_TESTING:BOOL=ON as a dedicated option to build the tests.
  • Add folder property globally and additionally to test targets to achieve better structuring in VS.

@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Oct 27, 2024
@beutlich beutlich added this to the MSL4.2.0 milestone Oct 27, 2024
@beutlich beutlich added the V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases) label Oct 27, 2024
@casella
Copy link
Contributor

casella commented Nov 11, 2024

@beutlich do you have suggestions for reviewers?

@beutlich
Copy link
Member Author

@beutlich do you have suggestions for reviewers?

I assigned @GallLeo and @maltelenz .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Resources Issue addresses Modelica/Resources (excl. C-Sources) V: 4.2.0-dev Issue originates in MSL v4.2.0-dev (and is not present in earlier releases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants