Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing __main__ in mcp_server_sentry #182

Merged

Conversation

aliev
Copy link
Contributor

@aliev aliev commented Dec 2, 2024

Description

In the current implementation, the __main__.py file and the call to the main() function are missing. As a result, the example from the "Using pip" section in the README does not work:

(.venv) ➜  mcp_server_sentry python -m mcp_server_sentry
/Users/ali/examples/.venv/bin/python: No module named mcp_server_sentry.__main__; 'mcp_server_sentry' is a package and cannot be directly executed

The issue is resolved by adding the __main__.py file with the main() function calling, which is exactly what this PR does:

(.venv) ➜  mcp_server_sentry python -m mcp_server_sentry
Usage: python -m mcp_server_sentry [OPTIONS]
Try 'python -m mcp_server_sentry --help' for help.

Error: Missing option '--auth-token'.
(.venv) ➜  mcp_server_sentry 

Server Details

  • Server: mcp_server_sentry
  • Changes to: mcp_server_sentry

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • New MCP Server
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My server follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jspahrsummers jspahrsummers merged commit 9cf2b66 into modelcontextprotocol:main Dec 3, 2024
9 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants