-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyze unsafe code reachability #3546
Open
celinval
wants to merge
3
commits into
model-checking:main
Choose a base branch
from
celinval:issue-xxxx-transitive-scan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
issue-xxxx-transitive-scan
branch
from
September 24, 2024 14:50
c208237
to
37bcc09
Compare
Add callgraph analysis to scanner in order to find the distance between functions in a crate and unsafe functions. For that, we build the crate call graph and collect the unsafe functions. After that, do reverse BFS traversal from the unsafe functions and store the distance to other functions. The result is stored in a new csv file.
celinval
force-pushed
the
issue-xxxx-transitive-scan
branch
from
September 24, 2024 14:54
37bcc09
to
c3d305f
Compare
celinval
commented
Sep 24, 2024
tautschnig
reviewed
Sep 24, 2024
celinval
force-pushed
the
issue-xxxx-transitive-scan
branch
from
January 31, 2025 20:43
025fe87
to
a4198ac
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
The old hack doesn't work anymore. I pulled this from #3546 per PR comment By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add call graph analysis to scanner in order to find the distance between functions in a crate and unsafe functions.
For that, we build the crate call graph and collect the unsafe functions. After that, do reverse BFS traversal from the unsafe functions and store the distance to other functions. The result is stored in a new csv file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.