-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use codegen_unimplemented() for the try intrinsic #275
Merged
adpaco-aws
merged 2 commits into
model-checking:main-153-2021-06-23
from
danielsn:try-intrinsic
Jun 30, 2021
Merged
use codegen_unimplemented() for the try intrinsic #275
adpaco-aws
merged 2 commits into
model-checking:main-153-2021-06-23
from
danielsn:try-intrinsic
Jun 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
avanhatt
approved these changes
Jun 30, 2021
adpaco-aws
approved these changes
Jun 30, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 2, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 9, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 15, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 26, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 2, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 6, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
* use codegen_unimplemented() for the try intrinsic * Additional unit test
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
* use codegen_unimplemented() for the try intrinsic * Additional unit test
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
* use codegen_unimplemented() for the try intrinsic * Additional unit test
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* use codegen_unimplemented() for the try intrinsic * Additional unit test
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* use codegen_unimplemented() for the try intrinsic * Additional unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use
codegen_unimplemented
to avoid problems that are blocking firecracker compilation.Along the way, discovered that we also require the
PointerCast::ClosureFnPointer
operation.Used
codegen_unimplemtned
for that too and raised an issue.Resolved issues:
Partial fix for #267 and #274 via
codegen_unimplemented()
Call-outs:
The actual semantics of try are complicated, discussed in the linked issues. But this unblocks that part of codegenning firecracker.
For now, marked the new test
fixme
.Testing:
How is this change tested? Additional regression test2, one for the raw intrinsic, one for the stabilized version. Both are currently marked
fixme
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.