Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use codegen_unimplemented() for the try intrinsic #275

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Jun 29, 2021

  • Refactor: Use borrowed types for arguments
  • use codegen_unimplemented() for the try intrinsic

Description of changes:

Use codegen_unimplemented to avoid problems that are blocking firecracker compilation.
Along the way, discovered that we also require the PointerCast::ClosureFnPointer operation.
Used codegen_unimplemtned for that too and raised an issue.

Resolved issues:

Partial fix for #267 and #274 via codegen_unimplemented()

Call-outs:

The actual semantics of try are complicated, discussed in the linked issues. But this unblocks that part of codegenning firecracker.

For now, marked the new test fixme .

Testing:

  • How is this change tested? Additional regression test2, one for the raw intrinsic, one for the stabilized version. Both are currently marked fixme

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@avanhatt
Copy link
Contributor

LGTM

@avanhatt avanhatt self-requested a review June 30, 2021 01:29
@adpaco-aws adpaco-aws merged commit 677451d into model-checking:main-153-2021-06-23 Jun 30, 2021
@danielsn danielsn deleted the try-intrinsic branch June 30, 2021 17:40
adpaco-aws pushed a commit that referenced this pull request Jul 2, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Jul 9, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Jul 15, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Jul 26, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Aug 2, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
@zhassan-aws zhassan-aws mentioned this pull request Aug 6, 2021
4 tasks
adpaco-aws pushed a commit that referenced this pull request Aug 6, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Aug 17, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
adpaco-aws pushed a commit that referenced this pull request Aug 24, 2021
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 22, 2022
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 25, 2022
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* use codegen_unimplemented() for the try intrinsic

* Additional unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants