-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify loop unwinding and general cleanup in Makefile.common #110
Merged
markrtuttle
merged 15 commits into
model-checking:master
from
markrtuttle:modernize-makefile-common+unwindset
May 9, 2022
Merged
Modify loop unwinding and general cleanup in Makefile.common #110
markrtuttle
merged 15 commits into
model-checking:master
from
markrtuttle:modernize-makefile-common+unwindset
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelonakos
reviewed
May 6, 2022
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
src/cbmc_starter_kit/template-for-repository/proofs/Makefile.common
Outdated
Show resolved
Hide resolved
tautschnig
approved these changes
May 7, 2022
angelonakos
approved these changes
May 9, 2022
nwetzler
approved these changes
May 9, 2022
This should close issue #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes conditional invocations of goto-instrument. The command goto-instrument is idempotent when called with no flags (it just copies the file), so checking whether a flag is set before calling goto-instrument is unnecessary and complicates the makefile.common.
This pull request also modifies when loop unwinding is done. It moves all loop unwinding of loops specified by UNWINDSET back to the invocations of cbmc (no more early invocation of goto-instrument to do it), but it does introduce a new EARLY_UNWINDSET to support selective loop unwinding for the purpose of function and loop contract checking.
This pull request also cleans up some comments in makefile.common and advances the release to 2.2.
These changes have been checked against all starter kit proofs in github. The differences found were
do
statement is no longer considered by cbmc to be contributing goto instructionsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.