[107] Add Instructions and Script To Run postgis Tests
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instructions are in CONTRIBUTING.md - Script is in root: `postgis-tests.sh`
There was a problem hiding this comment.
It looks good to me but I still have to test it locally to make sure that is working fine. 👍🏽
Thanks for your contribution, @timjklein36!
`spn` -> `spin` Co-authored-by: Ana Paula Gomes <[email protected]>
berinhard
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
This PR is great! @anapaulagomes I tested it locally and it worked just fine. I'm a debian user, so that worked for me. But it would be interesting to review this PR in other distros/OS, such as macOS. Can you help us too @amureki ?
| python -m pytest | ||
|
|
||
| # Spin down the postgis container | ||
| docker stop modelbakery |
|
Sure, I can also take a look to see how it works on MacOS. And thank you very much @timjklein36 for your contribution! |
amureki
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #107.
Instructions for running
postgresandpostgistests locally have been added toCONTRIBUTING.md. The instructions explain a way to run the tests against a database that is run usingdocker.A script,
postgis-tests.sh, has been added to do the heavy lifting for the user (once the dependencies have been installed). It may be desired to turn that into amaketarget in the future.Why
This provides a clean and reproduceable way to run the
postgresandpostgisspecific tests locally.How
Follow the instructions in the
CONTRIBUTING.mdfile. Comment on this PR if anything does not work or is missing.