Fix _model annotation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamkush
force-pushed
the
annotation-fix
branch
from
a80b192 to
e44ff92
Compare
berinhard
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks for your PR @noamkush =)
I'll wait for an extra review from @amureki or @anapaulagomes and we'll merge this in
|
PS.: I've updated your base branch to |
anapaulagomes
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks for your contribution, @noamkush. Please don't forget about updating the CHANGELOG.
noamkush
force-pushed
the
annotation-fix
branch
from
e44ff92 to
4c1d399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
_modelargument annotation in a few places where it can be either a class or str (I'm not sure whether it would be better to create an alias).