Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade crypto functions to support OTP 23 #231

Merged

Conversation

src/mochiweb_socket.erl Outdated Show resolved Hide resolved
@noahshaw11
Copy link
Contributor Author

noahshaw11 commented May 29, 2021

See apache/couchdb-mochiweb#5 (comment) for an explanation on why a recompiled rebar file was provided. This file can be recompiled by the following commands:

asdf install erlang R15B03-1
asdf erlang shell R15B03-1
git clone https://github.com/rebar/rebar.git
cd rebar/ && ./bootstrap
chmod +x rebar

@noahshaw11 noahshaw11 force-pushed the upgrade-crypto-functions-to-support-OTP-23 branch from 383527f to 44eade1 Compare May 29, 2021 01:00
@noahshaw11 noahshaw11 requested a review from etrepum May 29, 2021 01:01
@noahshaw11 noahshaw11 force-pushed the upgrade-crypto-functions-to-support-OTP-23 branch from bb48902 to f11baf7 Compare June 1, 2021 16:07
@noahshaw11 noahshaw11 force-pushed the upgrade-crypto-functions-to-support-OTP-23 branch from c34591b to dae0ac3 Compare June 1, 2021 16:11
@noahshaw11
Copy link
Contributor Author

@etrepum Backwards compatibility should be functional now. Thank you for the review!

Copy link
Member

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@etrepum etrepum merged commit 448984c into mochi:master Jun 4, 2021
@noahshaw11 noahshaw11 deleted the upgrade-crypto-functions-to-support-OTP-23 branch June 4, 2021 17:02
@etrepum
Copy link
Member

etrepum commented Jun 7, 2021

I've just tagged a release including this update https://github.com/mochi/mochiweb/releases/tag/v2.21.0

@noahshaw11
Copy link
Contributor Author

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants