createElement, appendChild should refer to "root" node's "ownerDocument" #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent.' for better browser support when HTML reporter is referencing a 'root' node in window.parent
…eateElement support -- refer to root.ownerDocument
Resolves mochajs#991 This expect statement expect("foo", "the foo").to.equal("bar"); now includes "the foo" as context for the failed match. 1) reporter shows reason for failed assertion: the foo + expected - actual +"bar" -"foo"
|
holy there's a lot of changes here and they're out of date. if you want to redo this pr with a minimal amount of changes that are fresh that'd be great. |
|
Sorry, the branch got gummed up with a lot of other changes – originally it was focused only on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #555.
For better browser support when the HTML reporter is referring to a
rootnode that is in anotherdocumentobject,createElementandappendChildoperations should be done with respect to therootnode'sownerDocument.By better browser support I mean that at least Firefox was throwing exceptions (and not running tests) when the
rootnode was in a differentdocumentcontext, i.e. the HTML reporter was running in an iframe.All tests passing after changes were made and mocha.js was rebuilt with
make all.