Runnable.timeout(0) no longer allows silent exits

[Schoonology]

Otherwise, it's possible to create an async test with a timeout of 0 and have Node exit silently. This way, it should be obvious the async test is malformed.

[Schoonology]

Updated pull request to match the expectations of http://visionmedia.github.io/mocha/#test-specific-timeouts

[tj]

this would have passed before as well no? maybe I'm reading it wrong

[Schoonology]

It would have. It's the pending test that would have caused all tests to exit. I removed that test when Sam Roberts and I discussed what this.timeout(0) should mean, and with the new behaviour (above), the test as it was implemented would instead cause the tests to never end.

If someone can come up with an awesome test for this.timeout(0), then the latter will no longer be pending. The former exists simply because there wasn't a test with this.timeout, as opposed to run.timeout. Minor, but it was useful for testing this issue, it could be useful for others.

[Schoonology]

Updated.

[tj]

actually it still behaves the way I'd expect:

describe('something', function(){
  it('should work', function(done){
    this.timeout(0);
    setTimeout(function(){
      done();
    }, 6000);
  })
})

executing after the 6s and exiting

[tj]

wrong button

[Schoonology]

The difference is the output if you don't have the setTimeout (making this hard to test):

describe('something', function () {
  it('should work', function (done) {
    this.timeout(0);
  })
})

I'll grant you that this is a malformed test. However, with a sufficiently complicated suite (like the one that elevated the issue), this kind of malformed test becomes less obvious than this. What the above test does is exit without a report. What it should do is never exit, indicating a problem, especially when used with a reporter like spec.

[tj]

ah ok i see what you're saying now

[bitwiseman]

👍

Once #860 is in, we can do this to test it:

describe('something', function () {
  it('should fail because timeout 0 waits forever', function (done) {
    this.timeout(0);
    setTimeout(function(){
      done('Boom!');
    }, 2000);
  })
})