Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove failing hyperlink linkcheck task #5176

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Although I like the idea of making sure links are correct, this is always failing and we don't change the site much anyway.

hyperlink is rarely used and hasn't been updated in a few years. Long-term it'd be great to move to a system with built-in link checking, like Docusaurus onBrokenLinks / other bits mentioned in withastro/starlight#946.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 11, 2024 01:30
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would really like to separate it out from this repo as well, or to make it a workspace within this repo

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 15, 2024 16:15
@voxpelli voxpelli merged commit 24560c1 into mochajs:main Jul 15, 2024
24 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-hyperlink branch July 15, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Repo: Netlify deploy previews failing all PR builds
2 participants