Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrade yargs from 16.2.0 to 17.6.0 #4939

Closed
wants to merge 1 commit into from

Conversation

apupier
Copy link

@apupier apupier commented Oct 31, 2022

fixes #4938

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Upgrading

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: apupier / name: Aurélien Pupier (8bc4c57)

@mattcollier
Copy link

@apupier It looks like you may have to deal with the CLA stuff here to get this PR in. Is that an issue for you? I'd like to see this go in to address a pesky Regex vulnerability that was fixed in 20.2.9 of yargs-parser.

@github-actions
Copy link
Contributor

This PR hasn't had any recent activity, and I'm labeling it stale. Remove the label or comment or this PR will be closed in 14 days. Thanks for contributing to Mocha!

@github-actions github-actions bot added the stale this has been inactive for a while... label Apr 19, 2023
@github-actions github-actions bot closed this May 5, 2023
@JoshuaKGoldberg
Copy link
Member

👋 coming back to this @apupier, are you still interested in working on this PR? As of #5027 there are maintainers who can review it now. No worries if you no longer have time - but if you do that'd be great!

@apupier
Copy link
Author

apupier commented Dec 4, 2023

Hi,
I'm sorry I do not have time to work on it these days.
I just try to rebase on top of main branch but there are several failing tests. You can use the code that I provided (even if it is almost nothing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale this has been inactive for a while...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade yargs dependency to 17.x
3 participants