Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop AMD/'RequireJS' #4857

Merged
merged 1 commit into from
Mar 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ const addSauceLabsTestName = (testName, cfg) =>
* - `tdd` - `tdd`-specific tests
* - `qunit` - `qunit`-specific tests
* - `esm` - ESM-specific tests
* - `requirejs` - RequireJS-specific tests
*
* Since we can't change Mocha's interface on-the-fly, tests for specific interfaces
* must be run in isolation.
Expand Down Expand Up @@ -297,10 +296,6 @@ const chooseTestSuite = (cfg, value) => {
case 'esm':
return addStandardDependencies({
...addSauceLabsTestName('ESM Integration Tests', cfg),
// just run against ChromeHeadless, since other browsers may not
// support ESM.
// XXX: remove following line when dropping IE11
browsers: ['ChromeHeadless'],
files: [
{
pattern: 'test/browser-specific/fixtures/esm.fixture.mjs',
Expand All @@ -312,26 +307,6 @@ const chooseTestSuite = (cfg, value) => {
}
]
});
case 'requirejs':
// no standard deps because I'm too lazy to figure out how to make
// them work with RequireJS. not important anyway
return {
...addSauceLabsTestName('RequireJS Tests', cfg),
plugins: [...cfg.plugins, 'karma-requirejs'],
frameworks: ['requirejs', ...cfg.frameworks],
files: [
{
pattern: 'test/browser-specific/fixtures/requirejs/*.fixture.js',
included: false
},
'test/browser-specific/requirejs-setup.js'
],
// this skips bundling the above tests & fixtures
rollup: {
...cfg.rollup,
include: []
}
};
default:
return addStandardDependencies({
...addSauceLabsTestName('Unit Tests', cfg)
Expand Down
38 changes: 0 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions package-scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ module.exports = {
browser: {
default: {
script:
'nps clean build test.browser.unit test.browser.bdd test.browser.tdd test.browser.qunit test.browser.esm test.browser.requirejs test.browser.webpack',
'nps clean build test.browser.unit test.browser.bdd test.browser.tdd test.browser.qunit test.browser.esm test.browser.webpack',
description: 'Run browser tests'
},
unit: {
Expand Down Expand Up @@ -234,11 +234,6 @@ module.exports = {
description: 'Run browser ES modules support test',
hiddenFromHelp: true
},
requirejs: {
script: 'cross-env MOCHA_TEST=requirejs nps test.browser.unit',
description: 'Run RequireJS compat test',
hiddenFromHelp: true
},
webpack: {
script:
'webpack --mode development --config ./test/browser-specific/fixtures/webpack/webpack.config.js',
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@
"karma-chrome-launcher": "^3.1.0",
"karma-mocha": "^2.0.1",
"karma-mocha-reporter": "^2.2.5",
"karma-requirejs": "^1.1.0",
"karma-sauce-launcher": "^4.3.6",
"lint-staged": "^10.2.11",
"markdown-it": "^12.3.2",
Expand All @@ -132,7 +131,6 @@
"remark": "^14.0.2",
"remark-github": "^11.2.2",
"remark-inline-links": "^6.0.1",
"requirejs": "^2.3.6",
"rewiremock": "^3.14.3",
"rimraf": "^3.0.2",
"rollup": "^2.70.1",
Expand Down
3 changes: 0 additions & 3 deletions test/browser-specific/fixtures/requirejs/lib.fixture.js

This file was deleted.

9 changes: 0 additions & 9 deletions test/browser-specific/fixtures/requirejs/main.fixture.js

This file was deleted.

17 changes: 0 additions & 17 deletions test/browser-specific/requirejs-setup.js

This file was deleted.