Exclude wrong sponsor image temporary #4570

outsideris · 2021-02-07T19:18:29Z

We fixed a bug for the supporter section on mochajs.org in #4569 .
Production build is still failed, but it is not related to #4569.

No sponsors nor backers image on mochajs.org is critical. So, I made a temporary fix by excluding that sponsor.

my tracking

As my tracking, downloaded sponsor image is fine, but Buffer data for the sponsor image is broken during making sprite-image.

This is the data we received from open collective and this avatar image(https://images.opencollective.com/codepilotai/732befb/logo/64.png) occurred the error.

{
  id: 'eeng0kzd-yvor4pz5-grpbma83-7xlw95jl',
  name: 'CodePilot.ai',
  slug: 'codepilotai',
  website: 'https://codepilot.ai',
  imgUrlMed: 'https://images.opencollective.com/codepilotai/732befb/logo/64.png',
  imgUrlSmall: 'https://images.opencollective.com/codepilotai/732befb/logo/32.png',
  firstDonation: '2018-02-09T23:39:30.388Z',
  totalDonations: 25000,
  type: 'ORGANIZATION',
  categories: [],
  avatar: 'https://images.opencollective.com/codepilotai/732befb/logo/64.png',
  tier: 'sponsor',
  dimensions: { width: 241, height: 64 }
}

This image saved to docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png. And this image is fine.

The stacktrace is like:

12:41:03 AM: (node:1403) UnhandledPromiseRejectionWarning: Error: Error loading docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png: Unsupported image type
12:41:03 AM:     at canvasImage.onerror (/opt/build/repo/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:16:9)
12:41:03 AM:     at setSource (/opt/build/repo/node_modules/canvas/lib/image.js:91:13)
12:41:03 AM:     at Image.set (/opt/build/repo/node_modules/canvas/lib/image.js:65:7)
12:41:03 AM:     at /opt/build/repo/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:21:21
12:41:03 AM:     at Promise._execute (/opt/build/repo/node_modules/bluebird/js/release/debuggability.js:384:9)
12:41:03 AM:     at Promise._resolveFromExecutor (/opt/build/repo/node_modules/bluebird/js/release/promise.js:518:18)
12:41:03 AM:     at new Promise (/opt/build/repo/node_modules/bluebird/js/release/promise.js:103:10)
12:41:03 AM:     at getCanvasImageFromImageAsset (/opt/build/repo/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:13:9)
12:41:03 AM:     at /opt/build/repo/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:257:11
12:41:03 AM:     at Array.map (<anonymous>)
12:41:03 AM:     at spriteBackgroundImages (/opt/build/repo/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:256:20)
12:41:03 AM:     at Immediate._onImmediate (/opt/build/repo/node_modules/assetgraph/lib/AssetGraph.js:648:25)
12:41:03 AM:     at processImmediate (internal/timers.js:461:21)

This is happened during our nps docs.postbuild.

On asseetgraph-sprite(see here), imageAsset.rawSrc is Buffer and Buffer data is broken.

<div class="sponsor" title="CodePilot.ai"
   style="width: 241px; background-image: url(/docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png?sprite=sponsors)">
</div>

This is from our index.html. So, I guess buildProduction load the Buffer data from /docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png. But I don't how assetgraph in details,
I believe @Munter can find a hint.

MCVE

This is MVCE to reproduce the issue.

<!DOCTYPE html>
<html lang="en">
  <body>
    <ul class="image-list" id="sponsors">
      <li><a href="https://codepilot.ai" target="_blank" rel="noopener">
        <div class="sponsor" title="CodePilot.ai"
             style="width: 241px; background-image: url(/docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png?sprite=sponsors)"></div>
      </a></li>
    </ul>
  </body>
</html>

The below image is /docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png.

If you run ./node_modules/.bin/buildProduction index.html --outroot _dist, you can see same error.

$ ./node_modules/.bin/buildProduction index.html --outroot _dist
Guessing --root from input files: file:///Users/outsider/Dropbox/projects/github/mocha/
 ✔ 0.005 secs: logEvents
 ✔ 0.048 secs: loadAssets
 ℹ INFO: Webpack is installed, but could not load the webpack config (tried webpack.config.js): Cannot find module 'webpack.config.js'
         Require stack:
         - node_modules/assetgraph-builder/bin/buildProduction
 ✔ 0.177 secs: bundleWebpack
 ✔ 0.001 secs: populate
 ✔ 0.001 secs: bundleSystemJs
 ✔ 0.000 secs: bundleRequireJs
 ✔ 0.003 secs: populate
 ✔ 0.000 secs: populate
 ✔ 0.000 secs: checkIncompatibleTypes
 ✔ 0.000 secs: removeRelations
 ✔ 0.000 secs: populate
 ✔ 0.000 secs: populate
 ✔ 0.000 secs: removeRelations
 ✔ 0.049 secs: addDataVersionAttributeToHtmlElement
 ✔ 0.000 secs: stripDebug
 ✔ 0.000 secs: externalizeRelations
 ✔ 0.000 secs: mergeIdenticalAssets
objc[66010]: Class GNotificationCenterDelegate is implemented in both /Users/outsider/Dropbox/projects/github/mocha/node_modules/canvas/build/Release/libgio-2.0.0.dylib (0x11679a2e0) and /Users/outsider/Dropbox/projects/github/mocha/node_modules/sharp/vendor/lib/libgio-2.0.0.dylib (0x13e014578). One of the two will be used. Which one is undefined.
 ✔ 0.123 secs: processImages
/Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib
(node:66010) UnhandledPromiseRejectionWarning: Error: Error loading 7 eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png - docs/_site/images/supporters/eeng0kzd-yvor4pz5-grpbma83-7xlw95jl.png: Unsupported image type
    at canvasImage.onerror (/Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:21:9)
    at setSource (/Users/outsider/Dropbox/projects/github/mocha/node_modules/canvas/lib/image.js:91:13)
    at Image.set (/Users/outsider/Dropbox/projects/github/mocha/node_modules/canvas/lib/image.js:65:7)
    at /Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:27:21
    at Promise._execute (/Users/outsider/Dropbox/projects/github/mocha/node_modules/bluebird/js/release/debuggability.js:384:9)
    at Promise._resolveFromExecutor (/Users/outsider/Dropbox/projects/github/mocha/node_modules/bluebird/js/release/promise.js:518:18)
    at new Promise (/Users/outsider/Dropbox/projects/github/mocha/node_modules/bluebird/js/release/promise.js:103:10)
    at getCanvasImageFromImageAsset (/Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:17:9)
    at /Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:273:18
    at Array.map (<anonymous>)
    at spriteBackgroundImages (/Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph-sprite/lib/spriteBackgroundImages.js:262:20)
    at Immediate._onImmediate (/Users/outsider/Dropbox/projects/github/mocha/node_modules/assetgraph/lib/AssetGraph.js:648:25)
    at processImmediate (internal/timers.js:461:21)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:66010) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:66010) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Additional issue.

This sponsor is CodePilot.ai, but the avatar image(https://images.opencollective.com/codepilotai/732befb/logo/64.png) is Netlify.
I believe this is open collective issue. I made an issue on Open Collective.

Signed-off-by: Outsider <[email protected]>

coveralls · 2021-02-07T19:29:27Z

Coverage remained the same at 94.129% when pulling 98847f1 on outsideris:temporary-fix-for-suppoters into 6dd12be on mochajs:master.

juergba · 2021-02-08T10:09:46Z

@outsideris Why has the build of yesterday's fix run successfully and the deploy-review shows sponsors/backers, but the production build fails. What is the difference? If one image is broken, shouldn't both builds fail?

outsideris · 2021-02-08T11:10:12Z

@juergba Because production build run optimization. So, the optimization failed because of the sponsor imaged.
We don't run it on PRs because the optimization takes a pretty long.

In terms of commands, difference between npm start docs.production and npm start docs.

juergba · 2021-02-08T15:09:05Z

I cherry-picked this commit to the mochajs.org branch and the sponsors/backers are back on stage.

outsideris · 2021-02-08T17:06:36Z

Great! I confirmed our sponsor/backer section is back.

juergba · 2021-02-09T09:15:43Z

IMO we shouldn't be bothered about the incorrect image. It's the one we get by opencollective (see https://opencollective.com/codepilotai ).
But what next to fix this error in a final manner?

juergba · 2021-02-09T09:40:11Z

I had a quick look at opencollective's API. The information lastTransactionAt seems to be available. We should list active sponsors/backers only and exclude the older ones (last donation more than one year ago).

outsideris · 2021-02-09T17:37:26Z

I've asked about the wrong image on OC OC said the sponsors didn't submit their logo. So, current wrong image is a fallback.(I don't know why it is netlify logo).
So, I think we cannot fix the wrong image.

Additionly, the image that we received is fine. I mean it is not a broken image.(just netlify logo, not codepilot.ai) The error occurred from our optimization to make css sprite-image. I don't know why yet.

I had a quick look at opencollective's API. The information lastTransactionAt seems to be available. We should list active sponsors/backers only and exclude the older ones (last donation more than one year ago).

I didn't know about lastTransactionAt. At this time, I also notice we show cumulative sponsors/backers. We need to discuss whether we show cumulative sponsors/backers or only current sponsors/backers.

juergba · 2021-02-10T16:58:07Z

@outsideris Your backer image is behaving very dominant. 😉
In Chrome on Windows:

juergba · 2021-03-02T19:49:27Z

With the URL https://opencollective.com/mochajs/members/all.json we can export our contributor data in JSON format.
The JSON file also includes a property lastTransactionAt to distinguish active from inactive sponsors/backers.
IMO we should exclude inactive contributors.

outsideris · 2021-03-05T12:25:44Z

Handling the excluding sponsors/backers in another issue is better.
So, I made #4595 .

juergba · 2021-03-07T09:23:45Z

@outsideris I think this PR #4362 is related.

outsideris · 2021-05-02T07:00:20Z

We don't need this anymore.

exclude wrong sponsor image temporary

98847f1

Signed-off-by: Outsider <[email protected]>

outsideris mentioned this pull request Mar 5, 2021

Exclude inactive sponsors and backers #4595

Closed

outsideris closed this May 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude wrong sponsor image temporary #4570

Exclude wrong sponsor image temporary #4570

outsideris commented Feb 7, 2021

coveralls commented Feb 7, 2021

juergba commented Feb 8, 2021 •

edited

Loading

outsideris commented Feb 8, 2021 •

edited

Loading

juergba commented Feb 8, 2021

outsideris commented Feb 8, 2021

juergba commented Feb 9, 2021

juergba commented Feb 9, 2021 •

edited

Loading

outsideris commented Feb 9, 2021

juergba commented Feb 10, 2021

juergba commented Mar 2, 2021

outsideris commented Mar 5, 2021

juergba commented Mar 7, 2021

outsideris commented May 2, 2021

Exclude wrong sponsor image temporary #4570

Exclude wrong sponsor image temporary #4570

Conversation

outsideris commented Feb 7, 2021

my tracking

MCVE

Additional issue.

coveralls commented Feb 7, 2021

juergba commented Feb 8, 2021 • edited Loading

outsideris commented Feb 8, 2021 • edited Loading

juergba commented Feb 8, 2021

outsideris commented Feb 8, 2021

juergba commented Feb 9, 2021

juergba commented Feb 9, 2021 • edited Loading

outsideris commented Feb 9, 2021

juergba commented Feb 10, 2021

juergba commented Mar 2, 2021

outsideris commented Mar 5, 2021

juergba commented Mar 7, 2021

outsideris commented May 2, 2021

juergba commented Feb 8, 2021 •

edited

Loading

outsideris commented Feb 8, 2021 •

edited

Loading

juergba commented Feb 9, 2021 •

edited

Loading