test helper improvements #4241
Merged
test helper improvements #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
type: chore
22 tasks
boneskull
commented
Apr 24, 2020
boneskull
force-pushed
the
boneskull/issue/2839-test-helpers
branch
from
056cb91 to
7484ab8
Compare
- enables `RawResult` (the result of `invokeMocha()` or `invokeMochaAsync()`) to check the exit code via `to have code` assertion - add passed/failing/pending assertions for `RawRunResult` (the result of `runMocha()` or `runMochaAsync()`) - expose `getSummary()`, which can be used with a `RawResult` (when not failing) - reorganize the module a bit - create `runMochaAsync()` and `runMochaJSONAsync()` which are like `runMocha()` and `runMochaJSON()` except return `Promise`s - better trapping of JSON parse errors - better default handling of `STDERR` output in subprocesses (print it instead of suppress it!) - do not let the `DEBUG` env variable reach subprocesses _unless it was explicitly supplied_ - add an easily copy-paste-able `command` prop to summary - add some missing docstrings Ref: #4198
boneskull
force-pushed
the
boneskull/issue/2839-test-helpers
branch
from
a3094b7 to
7ddcf5f
Compare
|
resolved conflict |
the same code should be in PR #4240
boneskull
force-pushed
the
boneskull/issue/2839-test-helpers
branch
from
7ddcf5f to
fe2c342
Compare
|
@mochajs/core any comments? |
arvidOtt
approved these changes
May 4, 2020
craigtaub
approved these changes
May 4, 2020
craigtaub
pushed a commit
that referenced
this pull request
May 21, 2020
* test helper improvements - enables `RawResult` (the result of `invokeMocha()` or `invokeMochaAsync()`) to check the exit code via `to have code` assertion - add passed/failing/pending assertions for `RawRunResult` (the result of `runMocha()` or `runMochaAsync()`) - expose `getSummary()`, which can be used with a `RawResult` (when not failing) - reorganize the module a bit - create `runMochaAsync()` and `runMochaJSONAsync()` which are like `runMocha()` and `runMochaJSON()` except return `Promise`s - better trapping of JSON parse errors - better default handling of `STDERR` output in subprocesses (print it instead of suppress it!) - do not let the `DEBUG` env variable reach subprocesses _unless it was explicitly supplied_ - add an easily copy-paste-able `command` prop to summary - add some missing docstrings Ref: #4198 * increase timeout in watch test for CI the same code should be in PR #4240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertions
RawResult(the result ofinvokeMocha()orinvokeMochaAsync()) to check the exit code viato have codeassertionRawRunResult(the result ofrunMocha()orrunMochaAsync())Integration test helpers
getSummary(), which can be used with aRawResult(when not failing)runMochaAsync()andrunMochaJSONAsync()which are likerunMocha()andrunMochaJSON()except returnPromisesSTDERRoutput in subprocesses (print it instead of suppress it!)DEBUGenv variable reach subprocesses unless it was explicitly suppliedcommandprop to summaryRef: #4198