ensure file is not in cache before calling require #3085
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #3084.
Alternate Designs
Could have modified
require.cache
directly, but seems easier to add thedecache
dependency and it handle modifying therequire.cache
for us.Why should this be in core?
Mocha makes an assumption that when loading files,
require(file)
will parse a file and encounter mocha directives. For this to be valid, mocha should ensure the file is not in the require cache.Benefits
Allows mocha to be used programmatically in scripts/environments where modules mocha is going to run tests on have already been loaded (perhaps by a previous invocation of mocha itself).
Possible Drawbacks
None that come to mind immediately, other than risk by having the
decache
dependency, though I think having that dependency makes sense here.Applicable issues
bug fix