fix(utils.js): diffs for buffers, issue #1132 #1368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| exports.bufferToJson = function (buf) { | ||
| return buf.toJSON | ||
| ? buf.toJSON(buf) |
There was a problem hiding this comment.
won't JSON.stringify() call the toJSON method of the buf object?
There was a problem hiding this comment.
likewise, in what instance will buf have a toJSON() method, or not?
|
please add test(s) |
|
anyway our diffs are pretty lame. I'd be interested in courting a 3p lib to do that |
|
@boneskull , I added tests and changed my PR a bit (actually we don't need the .toJSON function). |
travisjeffery
force-pushed
the
master
branch
2 times, most recently
from
35c1580 to
64dfc0b
Compare
|
lgtm just gonna squash it first |
|
this is resolved by 7a41fc2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: issue #1132