Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#888 Fix for --watch+only() issue #1172

Merged
merged 1 commit into from
Sep 13, 2014
Merged

Conversation

startswithaj
Copy link
Contributor

If mocha.grep is set via .only() we want to clear the grep on each --watch rerun(). If the grep is set vis option --grep we want it to persist. This resolves #888

@Guuz
Copy link

Guuz commented Aug 5, 2014

Can this get merged?

@bkudria
Copy link

bkudria commented Sep 10, 2014

+1

boneskull pushed a commit that referenced this pull request Sep 13, 2014
#888 Fix for --watch+only() issue
@boneskull boneskull merged commit 98286f2 into mochajs:master Sep 13, 2014
@boneskull
Copy link
Contributor

@startswithaj Thanks!

@rstacruz
Copy link
Contributor

any chance of a 1.22.1 release with this?

@Rob-ot
Copy link

Rob-ot commented Nov 28, 2014

I just noticed this was fixed, <3!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--watch and .only conflict
6 participants