Running the test suite twice skips tests that were already required

[ghost]

I wanted to run the test suite twice against different browsers on Saucelabs. I'm using the technique to run mocha programatically but on the second run mocha would always report that it did not run any tests.

After a lot of digging around it seems that since mocha uses require() to load the test files, they get cached and if they're cached they're not added to the suite.

I can manually clear all the tests from the require cache, but I'm wondering if maybe mocha shouldn't do this by default?

This is a simplified example of what I end up doing for it to work:

var Mocha = require('mocha');
var path  = require('path');

var testFile = path.resolve(__dirname, './test_file.js');

var set1 = new Mocha({ui: 'tdd'});
set1.addFile(testFile);

var set2 = new Mocha({ui: 'tdd'});
set2.addFile(testFile);

set1.run(function(failures1){
  console.log(require.cache['/Users/patrick/Downloads/mocha_argh/test_file.js']);
  // Need to delete the test from the cache or else
  // the test won't run.
  delete require.cache['/Users/patrick/Downloads/mocha_argh/test_file.js'];
  set2.run(function(failures2){
    process.exit(failures1 && failures2);
  });
});

[ghost]

I know it's somewhat of an edge case, but at least maybe something should be added to the documentation to explain that behavior.

[tj]

hmm yeah that's not good, I'll try and look into this soon and see where the state is at

[sebv]

+1

[cruiser12]

+1

[vbarach]

+1

[ririvas]

+1

[jreichenberg]

+1 ... Use case: we are trying to do this in order to run mocha multiple times in a grunt task, against different webdriver configurations

[dogeatdog]

+1, any progress with this ?

[ToshioMagic]

+1 this would be really useful. Running mocha tests on a backend but when I click a button on the frontend to redo the tests, it refuses because of caching.

[MichaelBorde]

+1

[db-ryan]

I think it is really easy to miss the workaround in the original post, this seems to work for me...

To add a file programmatically:

var filename = '/Users/patrick/Downloads/mocha_argh/test_file.js';
delete require.cache[filename];
mocha.addFile(filename);

Basically, every time you add a test to your mocha instance, just delete the cache for that file (whether it exists or not).

[boneskull]

@psturc would @1999's fix in #2435 solve your issue?

[psturc]

@boneskull Yes, @1999's solution does work for me. 👍

[donaldpipowitch]

Do I read the PRs correctly so this should work when v3.1 is released...? 92f0248#diff-aa849a970cef551664c12f04a4209f6fR354 Will this be called automatically?

Can I run the test suites in parallel? (E.g. it looks like most people in this issue try to run one Mocha test suite multiple times for different browsers in Selenium/Sauce Labs/etc..)

[1999]

Can I run the test suites in parallel

Probably mocha-parallel-tests is what you need?

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!

[boneskull]

not stale

[ghost]

Weird, I am getting proper (error) output the first time it runs, second time it runs in the same context I get 0 passing like nothing is running.

[ScottFreeCode]

@megamindbrian Sounds like a variation on #2906.

[ghost]

Oh looks like it could be, thank you for finding it!

…

On Tue, Nov 7, 2017 at 12:10 AM, Scott Santucci ***@***.***> wrote: @megamindbrian <https://github.com/megamindbrian> Sounds like a variation on #2906 <#2906>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#736 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5Xbpz8tXHTb8lQCDVzZPD0LdJIWWAFks5s0AJKgaJpZM4AYZE-> .

-- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

[akhilesharora]

+1, any progress with this ?

[RyanLiuF]

+1, any progress with this ?

[craigtaub]

Closing as believe it is now fixed (#4234)