Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: HTML reporter grep links do not respect fgrep, handle existing ? wrong #2300

Open
ScottFreeCode opened this issue Jun 9, 2016 · 0 comments
Open

🐛 Bug: HTML reporter grep links do not respect fgrep, handle existing ? wrong #2300

ScottFreeCode opened this issue Jun 9, 2016 · 0 comments
Labels
area: browser browser-specific area: reporters involving a specific reporter status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@ScottFreeCode
Copy link
Contributor

The grep links in the HTML reporter replace an existing grep=... parameter in the URL, but not fgrep=.... Furthermore, they tend to append an extra ? if ?fgrep=... is already in the URL instead of appending with & in that case.

Note that this code is in the same area as #2285.
@ScottFreeCode ScottFreeCode mentioned this issue Jun 9, 2016
Closed
ScottFreeCode added a commit that referenced this issue Mar 5, 2017
@ScottFreeCode
fix #2300
9fcaca9
@ScottFreeCode ScottFreeCode mentioned this issue Mar 5, 2017
Closed
@drazisil drazisil added type: bug a defect, confirmed by a maintainer area: reporters involving a specific reporter labels Mar 30, 2017
@ScottFreeCode ScottFreeCode added the area: browser browser-specific label Sep 22, 2017
@JoshuaKGoldberg JoshuaKGoldberg changed the title HTML reporter grep links do not respect fgrep, handle existing ? wrong 🐛 Bug: HTML reporter grep links do not respect fgrep, handle existing ? wrong Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Mocha can use your help with this one! label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser browser-specific area: reporters involving a specific reporter status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/html reporter mochajs/mocha
3 participants
@drazisil @JoshuaKGoldberg @ScottFreeCode