When using --delay, .only() no longer works

[wlingke]

When I run a test with --delay, and I specify only(), the entire test suite gets run, not just the only block.

[boneskull]

@wlingke can you please provide some example code

[wlingke]

run below with --delay will fail yield in test two being run.

var assert = require('assert')
setTimeout(function(){

    describe.only('Should only run this', function(){
        it('passing test', function(){
            assert(true)
        })
    });

    describe('Should not run this', function(){
        it('failing test', function(){
            assert(false)
        })
    });

    run()
}, 1000);

[trueter]

Can confirm.

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!

[JustinLivi]

Can confirm to keep this from closing.

[ScottFreeCode]

Yup, tried it out and this is still an issue.

Surprising, because only got redesigned and rewritten in version 3.

[ScottFreeCode]

Fix: move

mocha/lib/runner.js

Lines 813 to 816 in 16ffca2

	// If there is an `only` filter
	if (hasOnly(rootSuite)) {
	filterOnly(rootSuite);
	}

to between

mocha/lib/runner.js

Line 824 in 16ffca2

function start () {

and

mocha/lib/runner.js

Line 825 in 16ffca2

self.started = true;

How to write tests for it though... probably will have to use the test/integration model with test/integration/fixtures...

[silviom]

Hi, @ScottFreeCode. I have created the following PR for the fix. Thanks for the instructions.
#3215

[juergba]

This issue can be closed, see PR #3215