Fix warnings, selectively re-enable -warn-error #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lwt >= 2.7.0 the new `Lwt_unix.bind` API is categorised as blocking since it will block under some circumstances. This patch fixes a warning by using the new interface. Note this code is not used by default. By default we use `uwt`. Signed-off-by: David Scott <[email protected]>
- many unused bindings - many bindings missing in pattern-matches - many ambiguous field names - many unused arguments Signed-off-by: David Scott <[email protected]>
Previously we used `Failure` as a quick means of jumping out of an expression to the exception handler. However `Failure` is a special exception where the string is only meant to be recorded, not matched. This patch uses a first-class `Enoent` exception. Note the `Failure "BADWALK"` case could never happen: no code will throw this error. Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
-wand-warn-errorcompiler arguments were lost with the switch tojbuilder. This PRLwt_unix.binddeprecation warning by using the newLwt_unix.Versioned.bind_2Failure <string>-wand selective-warn-error