Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test upgrade grpc/protobuf #3039

Closed
wants to merge 1 commit into from
Closed

Conversation

crazy-max
Copy link
Member

Just testing grpc upgrade. ref moby/moby#42983 (comment)

cc @thaJeztah

Signed-off-by: CrazyMax [email protected]

@crazy-max
Copy link
Member Author

# github.com/docker/swarmkit/vendor/github.com/coreos/etcd/clientv3/balancer/resolver/endpoint
vendor/github.com/coreos/etcd/clientv3/balancer/resolver/endpoint/endpoint.go:114:78: undefined: resolver.BuildOption
vendor/github.com/coreos/etcd/clientv3/balancer/resolver/endpoint/endpoint.go:182:31: undefined: resolver.ResolveNowOption
# github.com/docker/swarmkit/vendor/github.com/coreos/etcd/clientv3/balancer/picker
vendor/github.com/coreos/etcd/clientv3/balancer/picker/err.go:37:44: undefined: balancer.PickOptions
vendor/github.com/coreos/etcd/clientv3/balancer/picker/roundrobin_balanced.go:55:54: undefined: balancer.PickOptions

@dperny Upgrading gRPC on this repo will require some effort because we need to also update etcd >= 3.5 to match the new grpc resolver signature (>= 1.27.0).

We might also need to update to Go 1.16 min before that (cc @errordeveloper).

@errordeveloper
Copy link
Contributor

We might also need to update to Go 1.16 min before that

Sure, let me try to do that!

@crazy-max
Copy link
Member Author

We might also need to update to Go 1.16 min before that

Sure, let me try to do that!

We should match the one from moby I guess (1.17.3 atm). cc @thaJeztah

@crazy-max
Copy link
Member Author

crazy-max commented Dec 3, 2021

@errordeveloper Not tested but I have a branch I just push if you want to take a look: https://github.com/crazy-max/swarmkit/tree/go117

Edit: see also moby/moby#42778 (comment)

@thaJeztah
Copy link
Member

We should match the one from moby I guess (1.17.3 atm). cc @thaJeztah

Yes, we should open a PR for that (can be separate from this one - hopefully will be an easy review/merge)

@dperny dperny closed this in #3051 Mar 7, 2022
@crazy-max crazy-max deleted the curr-moby branch March 7, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants