Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update issue on where service doesn't roll back on failure #3003

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

awmirantis
Copy link
Contributor

Signed-off-by: Adam Williams [email protected]
- What I did
When the updateConfig delay parameter is larger than the monitor parameter an error in updating can be missed and rollback not performed. This fix will check for the case where monitor < delay and use the larger of the two.

Fixes 37972
- How I did it

- How to test it
Manual testing that failed update will rollback.
- Description for the changelog

@awmirantis
Copy link
Contributor Author

awmirantis commented May 14, 2021

This test succeeds for me when ran locally. Could someone (@dperny @thaJeztah) kick off a replay for me?

@awmirantis awmirantis marked this pull request as ready for review May 17, 2021 19:25
@thaJeztah
Copy link
Member

I restarted CI; in the meantime we also updated some vendoring, so perhaps good to rebase this PR.

Do you think it's possible to write a test for this, or complicated?

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #3003 (3f633b2) into master (62d78f2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 3f633b2 differs from pull request most recent head fc1338c. Consider uploading reports for the commit fc1338c to get more accurate results

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   60.82%   60.79%   -0.04%     
==========================================
  Files         142      142              
  Lines       20295    20297       +2     
==========================================
- Hits        12345    12340       -5     
+ Misses       6494     6493       -1     
- Partials     1456     1464       +8     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swarm service: automatic rollback does not work - "good" container gets killed, service down
3 participants