API: remove deprecated "filter" parameter for API v1.41 and up #40491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query-parameter was deprecated in docker 1.13 in commit 820b809, and scheduled for removal in docker 17.12, so we should remove it for the next API version. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Although I have to wonder if it's worth the removal if it's only taking out those few lines... but 🤷♂ |
Yeah, it's a small change, but we deprecated it for removal, so might as well keep the API clean a bit 😅 CI is green; I'll bring this one in (thanks!) |
This was referenced Jun 27, 2020
kcq
added a commit
to slimtoolkit/slim
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query-parameter was deprecated in docker 1.13 in commit 820b809 (#27872), and scheduled for removal in docker 17.12, so we should remove it for the next API version.