Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump vndr to f5ab8fc5f, and revendor #39216

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Conversation

thaJeztah
Copy link
Member

The latest version of vndr preserves go.mod in vendored dependencies, which makes it easier to check if other dependencies need to be updated as well

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@AkihiroSuda
Copy link
Member

22:42:11 The result of vndr differs
22:42:11 
22:42:11  M vendor/github.com/moby/buildkit/go.mod
22:42:11 
22:42:11 Please vendor your package with github.com/LK4D4/vndr.

@thaJeztah
Copy link
Member Author

hm interesting; let me try running it again

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@70f67c6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39216   +/-   ##
=========================================
  Coverage          ?   37.32%           
=========================================
  Files             ?      609           
  Lines             ?    45197           
  Branches          ?        0           
=========================================
  Hits              ?    16868           
  Misses            ?    26040           
  Partials          ?     2289

@thaJeztah
Copy link
Member Author

I have no idea why vendor check is failing; I ran vndr again, but it gave no changes on my machine, but vendor is still failing;

16:48:24 2019/05/17 16:48:24 Running time: 1m29.172936525s
16:48:24 The result of vndr differs
16:48:24 
16:48:24  M vendor/github.com/moby/buildkit/go.mod
16:48:24 
16:48:24 Please vendor your package with github.com/LK4D4/vndr.

It shows M though (modified), so wondering if it's a newline issue, or perhaps whitespace? weird.

@tiborvass tiborvass changed the title bump vndr to v0.0.3, and revendor bump vndr to f5ab8fc5f, and revendor Jun 27, 2019
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@tiborvass
Copy link
Contributor

@thaJeztah I think it just needs a rebase. Hopefully this time it's good!

@tiborvass
Copy link
Contributor

For the record I changed vndr to f5ab8fc5f to include LK4D4/vndr#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants