-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference
filter to the list of available filters
#31969
Add reference
filter to the list of available filters
#31969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -158,6 +158,7 @@ The currently supported filters are: | |||
* label (`label=<key>` or `label=<key>=<value>`) | |||
* before (`<image-name>[:<tag>]`, `<image id>` or `<image@digest>`) - filter images created before given id or references | |||
* since (`<image-name>[:<tag>]`, `<image id>` or `<image@digest>`) - filter images created since given id or references | |||
* reference (pattern of an image reference) - filter images whose reference matches the specified pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR per-se, but perhaps we should add anchor links to the sections below (like we do on other pages)
Oh, actually; this also needs to go into the man page; https://github.com/docker/docker/blob/master/man/src/image/ls.md#filters |
The `reference` filter is documented in the file, but is not present in the list of available filters. Signed-off-by: Vincent Demeester <[email protected]>
36006d1
to
8e7e6bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😅
…cs-filter-list Add `reference` filter to the list of available filters (cherry picked from commit 4c7941d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
…cs-filter-list Add `reference` filter to the list of available filters (cherry picked from commit 4c7941d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
relates to #27872 |
The
reference
filter is documented in the file, but is not presentin the list of available filters.
/cc @thaJeztah @mstanleyjones
🐯
Signed-off-by: Vincent Demeester [email protected]