Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference filter to the list of available filters #31969

Merged

Conversation

vdemeester
Copy link
Member

The reference filter is documented in the file, but is not present
in the list of available filters.

/cc @thaJeztah @mstanleyjones

🐯

Signed-off-by: Vincent Demeester [email protected]

thaJeztah
thaJeztah previously approved these changes Mar 21, 2017
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -158,6 +158,7 @@ The currently supported filters are:
* label (`label=<key>` or `label=<key>=<value>`)
* before (`<image-name>[:<tag>]`, `<image id>` or `<image@digest>`) - filter images created before given id or references
* since (`<image-name>[:<tag>]`, `<image id>` or `<image@digest>`) - filter images created since given id or references
* reference (pattern of an image reference) - filter images whose reference matches the specified pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR per-se, but perhaps we should add anchor links to the sections below (like we do on other pages)

@thaJeztah
Copy link
Member

Oh, actually; this also needs to go into the man page; https://github.com/docker/docker/blob/master/man/src/image/ls.md#filters

The `reference` filter is documented in the file, but is not present
in the list of available filters.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the fix-images-reference-docs-filter-list branch from 36006d1 to 8e7e6bd Compare March 21, 2017 15:11
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😅

@thaJeztah thaJeztah merged commit 4c7941d into moby:master Mar 21, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 21, 2017
@vdemeester vdemeester deleted the fix-images-reference-docs-filter-list branch March 21, 2017 15:14
@thaJeztah thaJeztah modified the milestones: 17.03.1, 17.05.0 Mar 21, 2017
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Apr 3, 2017
…cs-filter-list

Add `reference` filter to the list of available filters
(cherry picked from commit 4c7941d)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Apr 3, 2017
…cs-filter-list

Add `reference` filter to the list of available filters
(cherry picked from commit 4c7941d)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member

relates to #27872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants