-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refer to mirage module types modules by new name #433
Conversation
CI failed with:
moby/datakit.logs@46c2ea4#diff-dc1d71bbb5c4d2a5e936db79ef10c19fR121 |
FWIW I think I saw the same error earlier today when building an ocaml package locally in an |
Signed-off-by: Mindy Preston <[email protected]>
I guess this needs to wait for Mirage 3 to be released. |
CentOS and Fedora are the only containers that use the Docker Cloud-hosted solver.ocaml.io, so you will see that error if the infra is down. The builds can be restarted. |
@talex5 if it bugs you to leave this PR open, I'm happy to resubmit it later or point it at a mirage-dev branch. |
I think it's fine to keep it open. I've tagged it as tracking. |
see moby/datakit#433 for upstream PR
V1 is now Mirage_types, and V1_LWT is now Mirage_types_lwt, as of MirageOS version 3.0.0.