cache: add tracing to prune #5627
Open
+142
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tracing to the cache manager prune operation. The attribute will show both explicit prunes from a user and background prunes initiated after solve requests are processed. The prune code has also been refactored a bit to remove a recursive call to prune. It has now been unrolled and the functions have been renamed so `prune` stands for the entire prune process and `pruneOnce` is a single cycle. Previously, `prune` was a single cycle and `pruneOnce` would run the entire prune cycle with a set of options. This also disabled the delve component of the `hack/compose` script. It appears to be broken at the moment. Signed-off-by: Jonathan A. Sternberg <[email protected]>
github-actions
bot
added
area/hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing to the cache manager prune operation. The attribute will show both explicit prunes from a user and background prunes initiated after solve requests are processed.
The prune code has also been refactored a bit to remove a recursive call to prune. It has now been unrolled and the functions have been renamed so
prunestands for the entire prune process andpruneOnceis a single cycle. Previously,prunewas a single cycle andpruneOncewould run the entire prune cycle with a set of options.This also disabled the delve component of the
hack/composescript. It appears to be broken at the moment.