Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.16] cherry-picks for v0.16.0 #5319

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

crazy-max
Copy link
Member

@github-actions github-actions bot added the area/dependencies Pull requests that update a dependency file label Sep 10, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit d8d946b into moby:master Sep 10, 2024
90 of 91 checks passed
@crazy-max crazy-max deleted the v0.16.0-picks branch September 10, 2024 14:46
@crazy-max
Copy link
Member Author

Damn was targeting the wrong branch but GitHub still says there are changes? 🤷‍♂️

@thaJeztah
Copy link
Member

Oh! That's odd. Perhaps because your master branch was out of date?

Should have a check similar to what we have in moby 😂

@crazy-max
Copy link
Member Author

Oh! That's odd. Perhaps because your master branch was out of date?

Should have a check similar to what we have in moby 😂

I think this is a GitHub UI issue, didn't have any changes in follow-up PR #5320 with exact same branch 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants