hack: update golangci-lint to 1.61 #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblock CI with the schema verify error in 1.60 Signed-off-by: Tonis Tiigi <[email protected]>
github-actions
bot
added
area/hack
tonistiigi
commented
Sep 9, 2024
| @@ -93,6 +93,7 @@ linters-settings: | |||
| - G402 # TLS MinVersion too low | |||
| - G504 # Import blocklist: net/http/cgi | |||
| - G601 # Implicit memory aliasing in for loop (false positives) | |||
| - G115 # integer overflow conversion (TODO: verify these) | |||
There was a problem hiding this comment.
same as moby/moby#48358 . Doesn't look like anything critical here, but we could use some pattern for avoiding overflow.
tonistiigi
commented
Sep 9, 2024
| @@ -37,10 +37,10 @@ func v0TarHeaderSelect(h *tar.Header) (orderedHeaders [][2]string) { | |||
|
|
|||
| func v1TarHeaderSelect(h *tar.Header) (orderedHeaders [][2]string) { | |||
| pax := h.PAXRecords | |||
| if len(h.Xattrs) > 0 { // field deprecated in stdlib | |||
| if len(h.Xattrs) > 0 { //nolint:staticcheck // field deprecated in stdlib | |||
There was a problem hiding this comment.
Looks like https://github.com/moby/buildkit/pull/5256/files#r1716936764 was some kind of bug in 1.60
AkihiroSuda
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock CI with the schema verify error in 1.60 golangci/golangci-lint#5003