-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linting rules for undeclared args in from #4843
Conversation
87dd6f5
to
7272349
Compare
You mean the cases where build already errors? I don't think we need special handling for these cases or to skip any actual errors. I think it would be enough if we can detect:
This is not invalid build but the |
Exactly what I meant, yes. |
9113680
to
606efdd
Compare
2bc87d4
to
eea0cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some errors in CI for latest version.
1c07614
to
45af41e
Compare
Signed-off-by: Talon Bowler <[email protected]>
043b19c
to
30a4b38
Compare
52948d4
to
1e0a955
Compare
1e0a955
to
8df3d9b
Compare
Okay, review ready again at last! 😂 |
…of parameters Signed-off-by: Talon Bowler <[email protected]>
8df3d9b
to
ca448aa
Compare
This adds another linting rule related to unmatched ARGs in the FROM command.