dockerfile: add suggestions to how to fix certain errors #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
commented
Jul 2, 2021
| @@ -243,7 +252,7 @@ func Dockerfile2LLB(ctx context.Context, dt []byte, opt ConvertOpt) (*llb.State, | |||
| } | |||
| d.stage.BaseName = reference.TagNameOnly(ref).String() | |||
| var isScratch bool | |||
| if metaResolver != nil && reachable && !d.unregistered { | |||
| if metaResolver != nil && reachable { | |||
There was a problem hiding this comment.
Copy from image will now load image config here although it is not needed to get an error in the correct place. The config would have been still downloaded together with the image layers before.
tonistiigi
commented
Jul 2, 2021
| @@ -23,7 +22,7 @@ func splitCommand(line string) (string, []string, string, error) { | |||
| } | |||
| } | |||
|
|
|||
| return cmd, flags, strings.TrimSpace(args), nil | |||
| return cmdline[0], flags, strings.TrimSpace(args), nil | |||
There was a problem hiding this comment.
Previously parser changed the casing of what the user had typed. This keeps it so that correct values can be shown on errors and should normalize to lowercase where it is actually needed.
AkihiroSuda
reviewed
Jul 2, 2021
|
|
||
| func commonImageNames() []string { | ||
| repos := []string{ | ||
| "alpine", "busybox", "centos", "debian", "golang", "ubuntu", "fedora", |
There was a problem hiding this comment.
CentOS is about to die soon :)
There was a problem hiding this comment.
(I noticed this is used only for typo-checking, so it's fine to retain centos here)
tonistiigi
force-pushed
the
error-suggest
branch
2 times, most recently
from
02c1e72 to
49524c6
Compare
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Closed
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 3, 2024
The lowercasing of the command value was undone to allow to print an error message with the original casing. moby/buildkit#2218 (comment) for more context.
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 3, 2024
The lowercasing of the command value was undone to allow to print an error message with the original casing. moby/buildkit#2218 (comment) for more context.
ingvagabund
added a commit
to ingvagabund/oc
that referenced
this pull request
Jul 4, 2024
The lowercasing of the command value was undone to allow to print an error message with the original casing. moby/buildkit#2218 (comment) for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects mistyped: