ensure containerd io is complete and closed before returning #2205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2133
The closing of the IO was not synchronized for containerd processes (both Exec and Run). The tests failed ~5% of the time with unexpected output from previous Exec calls because we reuse the buffers but they continued to be written to after the
Reset
calls. We just need to wait for the IO to complete before returning from Exec/Run. I ran the test 1000 times in a row with no errors: