Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure containerd io is complete and closed before returning #2205

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

coryb
Copy link
Collaborator

@coryb coryb commented Jun 28, 2021

fixes #2133

The closing of the IO was not synchronized for containerd processes (both Exec and Run). The tests failed ~5% of the time with unexpected output from previous Exec calls because we reuse the buffers but they continued to be written to after the Reset calls. We just need to wait for the IO to complete before returning from Exec/Run. I ran the test 1000 times in a row with no errors:

TESTPKGS="./worker/containerd" TESTFLAGS="-v --count=1000 --parallel=6 --failfast --timeout=120m -run TestContainerdWorkerIntegration/TestContainerdWorkerExec$" ./hack/test integration

@tonistiigi tonistiigi merged commit 63b1249 into moby:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec tests are flaky
2 participants