Merge pull request #4119 from crazy-max/v0.12_backport_fix-filesync

[0.12 backport] filesync: write closer err discarded
moby · Aug 8, 2023 · 2a6aace · 2a6aace
2 parents 6579892 + 1c5387a
commit 2a6aace
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/session/filesync/filesync.go b/session/filesync/filesync.go
@@ -286,7 +286,7 @@ func (sp *fsSyncTarget) DiffCopy(stream FileSend_DiffCopyServer) (err error) {
 	}
 	defer func() {
 		err1 := wc.Close()
-		if err != nil {
+		if err == nil {
 			err = err1
 		}
 	}()