Merge pull request #4389 from liulanzheng/master

fix usage loss for snapshots with labels in MergeSnapshotter
moby · Nov 3, 2023 · 257622c · 257622c
2 parents 36c5550 + 6fe2ee8
commit 257622c
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/snapshot/merge.go b/snapshot/merge.go
@@ -185,19 +185,25 @@ func mergeUsageOf(info snapshots.Info) (usage snapshots.Usage, ok bool, rerr err
 	if info.Labels == nil {
 		return snapshots.Usage{}, false, nil
 	}
+	hasMergeUsageLabel := false
 	if str, ok := info.Labels[mergeUsageSizeLabel]; ok {
 		i, err := strconv.Atoi(str)
 		if err != nil {
 			return snapshots.Usage{}, false, err
 		}
 		usage.Size = int64(i)
+		hasMergeUsageLabel = true
 	}
 	if str, ok := info.Labels[mergeUsageInodesLabel]; ok {
 		i, err := strconv.Atoi(str)
 		if err != nil {
 			return snapshots.Usage{}, false, err
 		}
 		usage.Inodes = int64(i)
+		hasMergeUsageLabel = true
+	}
+	if !hasMergeUsageLabel {
+		return snapshots.Usage{}, false, nil
 	}
 	return usage, true, nil
 }