Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observe: Use typescript index types #817

Closed
wants to merge 1 commit into from
Closed

Conversation

Strate
Copy link
Contributor

@Strate Strate commented Feb 3, 2017

This enables better typecheck and inference.

This enables better typecheck and inference.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.226% when pulling 389edb8 on observe_ts_index_types into bc9efb1 on master.

@hccampos
Copy link

hccampos commented Feb 3, 2017

This will break compatibility for everyone using TS < 2.1 if I am not mistaken. Would probably warrant a major version bump

@mweststrate
Copy link
Member

Great @Strate! Thanks for pointing out @hccampos, will indeed be breaking for TS 2.0 users. Will merge it as soon as MobX 4 is nigh. Note that MobX 3 won't be as long lived as MobX 2, so shouldn't take too long :)

@mweststrate mweststrate mentioned this pull request Jul 4, 2017
14 tasks
@mweststrate mweststrate mentioned this pull request Feb 27, 2018
38 tasks
@mweststrate
Copy link
Member

Merged into #1321, closing here.

mweststrate added a commit that referenced this pull request Feb 28, 2018
@mweststrate mweststrate deleted the observe_ts_index_types branch March 7, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants