Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for toPrimitive and valueOf on computed and observable values #782

Merged
merged 3 commits into from
Jan 19, 2017
Merged

Add support for toPrimitive and valueOf on computed and observable values #782

merged 3 commits into from
Jan 19, 2017

Conversation

mweststrate
Copy link
Member

Merges #773, implements #561

eladnava and others added 3 commits January 17, 2017 21:01
@eladnava
Add support for Symbol.toPrimitive() and valueOf() on observables #Go…
211a5a8 
…odnessSquad

As per #561.
Big thanks to @wildeyes for helping me!

Note: `console.log(mobx.observable(3))` returns `ObservableValue` and
not `3`. Is this okay?

#GoodnessSquad
@mweststrate
Merge branch 'symbol-toprimitive-support' of https://github.com/eladn…
1b13355 
…ava/mobx into eladnava-symbol-toprimitive-support
@mweststrate
Some improvements to toPrimitive
aa6a00c
@mweststrate mweststrate changed the title Eladnava symbol toprimitive support Add support for toPrimitive and valueOf on computed and observable values Jan 19, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 96.19% when pulling aa6a00c on eladnava-symbol-toprimitive-support into 9537b6a on master.

@mweststrate mweststrate merged commit c7449df into master Jan 19, 2017
@mweststrate
Copy link
Member Author

Released as part of 3.0.2. Thanks!

@mweststrate mweststrate deleted the eladnava-symbol-toprimitive-support branch March 30, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweststrate @coveralls @eladnava