-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ide typescript compatability in __tests__ dir #3620
Conversation
|
Thanks for looking into it. Isn't there the same issue with |
Added a fix for it in 9409d73
I was able to see this issue within VSCode and after 9409d73 it's fixed. |
ce5e514
to
1dc8f15
Compare
@urugator would you like me to close this or is it still needed ? |
No please keep it open. The PR is very much appreciated, I (or someone else) will get to it eventually. There are just other issues I would like to settle first and I don't want to accidentaly complicate their resolution due to config changes or something. Sorry for the delay. |
Description
While having a look at #3590 I found out that
WeakRef
was not defined althoughESNext
was being in use.Apparently VSCode and most LSP servers don't recognise
tsconfig.test.json
and the directory was explicitly excluded from the project root, onlytsconfig.json
is recognised.This PR aims at fixing Developer Experience while working within
__tests__
for bothmobx-react
andmobx-react-light
packages.Hope I am helping.
Cheers.