feat: derivationRequiresObservable & observablesRequiresReaction (mobx4) #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derivationRequiresObservable & observablesRequiresReaction
Bnaya
force-pushed
the
observables-requires-derivation-mobx4
branch
from
c8cbedf to
4c48475
Compare
|
Kinda unfortunate to use completely different PR title, looks like a different thing. Nonetheless, it looks the same code-wise, so worry about V5 first. Edit: I see it actually breaks some tests here? |
|
its the automated PR title - i will edit it, |
Bnaya
changed the title
Bnaya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2079 for mobx4